fix: Use hiera auto data binding for base::packages::shells

data/common.yaml

@@ -0,0 +1,9 @@
+lookup_options:
+  base::packages::shells:
+    merge: unique
+
+base::packages::shells::shells:
+  - bash
+  - zsh
+  - ksh
+  - fish

hiera.yaml

@@ -5,11 +5,9 @@ defaults:
   # file (this file)
   # When specifying a datadir, make sure the directory exists.
   # See https://puppet.com/docs/puppet/latest/environments_about.html for further details on environments.
-  # datadir: data
-  # data_hash: yaml_data
+  datadir: data
+  data_hash: yaml_data
+
 hierarchy:
-  - name: "Per-node data (yaml version)"
-    path: "nodes/%{::trusted.certname}.yaml"
-  - name: "Other YAML hierarchy levels"
-    paths:
-      - "common.yaml"
+  - name: "Global Base Configuration"
+    paths: "common.yaml"

modules/base/manifests/init.pp

@@ -1,4 +1,5 @@
 class base inherits base::params {
   include base::users
   include base::dummy
+  include base::packages
 }

modules/base/manifests/packages.pp

@@ -0,0 +1,12 @@
+class base::packages {
+    include base::packages::shells
+}
+
+class base::packages::shells {
+    $shells.each | String $value | {
+        package { "${value}":
+            ensure => installed,
+            name   => "${value}",
+        }
+    }
+}

modules/security/manifests/firewall.pp

@@ -9,7 +9,7 @@ class security::firewall::nftables {
     name   => 'nftables',
   }
   ~> file { default: *=> $security::params::file_defaults;
-    "/etc/nftables.conf":
+    '/etc/nftables.conf':
       ensure => present,
       source => 'puppet:///modules/security/firewall/nftables/nftables.conf',
     ;